Multi tool use

'str' object has no attribute 'close with popen.python

I am using the command os.popen in python and when I try to close it I get the error:

os.popen

'str' object has no attribute 'close


how can I fix this?
I tried reading it repeatedly in another line but this still didn't work.
this is the code lines:

p = os.popen(command, "r").read()
f_temp_command = open("%s/%s%s" % (LOG_DIR, file, LOG_EXT), "w")
f_temp_command.writelines([l for l in p.splitlines()])
p.close()


2 Answers
2

This

p = os.popen(command, "r").read()


binds p to the result of .read(), not to the result of os.popen(). You want:

p

.read()

os.popen()

p = os.popen(command, "r")
r = p.read()
do_something_with(r)
p.close()


or better:

with os.popen(command, "r") as p:
r = p.read()
# no need to close p anymore, it's already done


As a side note, you don't need the list expression here:
f_temp_command.writelines([l for l in r.splitlines()])

since r.splitlines() already returns a list, so you could replace it with:

r.splitlines()

f_temp_command.writelines(r.splitlines())


or even with:

f_temp_command.write(r)


splitlines()

p.read()

r

You can not close it bacause read method return str object. Use an intermediate variable to store the result.

read

str

p = os.popen(command, "r")
res = p.read()
f_temp_command = open("%s/%s%s" % (LOG_DIR, file, LOG_EXT), "w")
f_temp_command.writelines([l for l in res.splitlines()])
p.close()


By clicking "Post Your Answer", you acknowledge that you have read our updated terms of service, privacy policy and cookie policy, and that your continued use of the website is subject to these policies.